Module talk:Item2

Star of Wraeclast

Now there is no Star of Wraeclast in unique amulet list, imho because it inherits drop disabled mark of its base type - Ruby Amulet. I think smth in this module need to be rewrited to fix it. Trympyrym (talk) 09:13, 12 May 2017 (UTC)

I disabled it from copying over from the base item because there are a few that are obtainable while the base items are not (except for vaaling I guess). This should fix for the time being, I'll get to making a proper fix for this eventually because the same issue could affect other properties that are copied from the base item --OmegaK2 (t|c) 17:10, 12 May 2017 (UTC)

Modifying skill gems tables to include sortable columns by tag

I was thinking about trying to modify this module so that skill gem tables would include sortable columns for each skill gem tag. For example on the Active Skill Gems page, we could be able to sort each column by which gems have the Attack tag or Minion tag. Does anyone have a general idea of how difficult would be? Does this sound like a worthwhile endeavor? Would anyone like to collaborate on this? Alleryn (talk) 20:30, 12 August 2017 (UTC)

There would be too many columns if you added one for each tag (over 30+ extra ones). A better solution would be with some javascript.--OmegaK2 (t|c) 21:42, 12 August 2017 (UTC)

Or what about snazzying up List_of_active_skill_gems_by_gem_tag and List_of_support_skill_gems_by_gem_tag, adding in some columns to show the minor attributes (e.g. if dex/int are needed on a red gem) and maybe some of the more relevant data like cast speed/crit chance/damage effectiveness. And then standardizing/templatizing (probably not a word) the pages that are list_of_x_gems, like List_of_skill_gems_dealing_spell_damage could be a part of a new page called List_of_spell_gems, which would also include List of Curses. Something like that. Does that sound like a reasonable approach for me to take? Thank you for your advice, OmegaK2 and any other respondents. Alleryn (talk) 02:59, 13 August 2017 (UTC)

Splitting the module

As mentioned it would be helpful to separate layout and backend. By layout I mean the item list/link. The backend consists of the item box and related code most likely.

Layout		Item box (on item hover)
Module:Item link		Module:Item
Module:Item list	Module:Item list/skill gems by gem tag
	Module:Item list/prophecies

This would have the benefit to not need to load the item list code for a simple item link. Furthermore new layouts such as prophecy lists for Prophecies can be designed without messing with Module:Item (or rather Module:Item2). The connection point would probably be a page string that can be passed to Module:Item. Molldust (talk) 21:55, 1 September 2017 (UTC)

Category:Divination cards

At the moment, the divination cards are in [[Category:Divination Card]] and should be in [[Category:Divination cards]].--Ruba159753 (talk) 11:37, 28 May 2018 (UTC)

Categories matching the item class are used for consistency. --OmegaK2 (t|c) 16:25, 28 May 2018 (UTC)

I agree with Ruba159753. It should be [[Category:Divination cards]]. Players cannot see the internal names of item classes unless they use tools that examine the game data. The internal name for the divination card item class could be "Prophecy Paper", but it's irrelevant to what is shown in game. —Vini (t|c) 17:31, 28 May 2018 (UTC)

Item classes are used in item filters, skill gem restrictions and queries over all the wiki, as I said on the CP I agree on the infoboxes, but the categories should stay as is. --OmegaK2 (t|c) 17:34, 28 May 2018 (UTC)

As addendum, the item classes are already the localized variants and not just the internals. I just remembered they're actually shown as well, for example when doing master crafting --OmegaK2 (t|c) 17:44, 28 May 2018 (UTC)

Huh.. It seems that you are correct. It's not such a big deal either way, but thanks for looking into it. —Vini (t|c) 23:23, 28 May 2018 (UTC)

Need map series categories in Category:Maps

At the moment, in the category:Maps are all series of maps, but it will be better if they are divided into series (as it is done with gem by tags, for example).--Ruba159753 (talk) 13:59, 17 December 2019 (UTC)

gems quality

Is it possible to change the display of gems quality so that they can be seen all at once? For example:
Per 1% Quality:
Superior: stat_text
Divergent: stat_text
Anomalous: stat_text
Phantasmal: stat_text
--Ruba159753 (talk) 12:52, 31 October 2020 (UTC)

Yes, but I thought it looked far too busy in the gem infobox, hence the selection. OmegaK2 (talk) 18:37, 31 October 2020 (UTC)

Quality names are important because they can be specified in item filter. Therefore, they should not be neglected.--Ruba159753 (talk) 08:40, 1 November 2020 (UTC)

Override implicit

GGG keeps adding Unique items that override their base item Implicit (Starforge, Replica Atziri's Foible)

Base item implicit should not be shown, or show stat text like this.

--SnosMe (talk) 08:07, 1 December 2020 (UTC)

I personally think it should show only the actual implicit that it has, rather than listing both, even if the default one is crossed out. The body of the articles for uniques that have altered implicits can describe the difference in more detail. —Vini (t|c) 11:19, 1 December 2020 (UTC)

Requires parameter

For some reason, the requires parameter and the associated code requires = 'Requires %s' is incorrectly displayed on decoration such as Maven's Astrolabe, Fellshrine Ruins (decoration)

However, the parameters "master", "master_level_requirement" are not displayed. Neokowloon (talk) 10:13, 26 April 2021 (UTC)

Some 3.14 change

may need to replace mana_multiplier = 'Mana Multiplier: %s',

to

mana_multiplier = 'Cost and Reservation Multiplier: %s',

Due to the change in in-game wording.

And may be need to add new parameter

life_cost = 'Cost: %s Life',

as new skill Reap, Corrupting Fever, Exsanguinate use life only

also modify

from

mana_cost = 'Mana Cost: %s',

to mana_cost = 'Cost: %s Mana',

and seem "Cost: %s Mana" and "Cost: %s Life" seem currently mutually exclusively so that if the value is null the other parameter should be hidden from infobox output. Neokowloon (talk) 09:37, 27 April 2021 (UTC)

Thanks for compiling that info. I'll work on these changes. —Vini (t|c) 20:56, 27 April 2021 (UTC)

On pypoe side L1mer haven't update the skill export yet so that he should be the one further follow up the life cost part implantation, but for now just switch the mana cost wording for existing infobox is fine i think. Neokowloon (talk) 21:01, 27 April 2021 (UTC)

• Spotted another thing:

mana_reserved = 'Mana Reserved: %s',

to

mana_reserved = 'Reservation: %s Mana',

Can't remember are there any skill reserve life naturally yet. Neokowloon (talk) 04:44, 28 April 2021 (UTC)

Also, it seems the infobox has more thing regarding mana cost such as

has_percentage_mana_cost, has_reservation_mana_cost, static_mana_cost, level[n]_mana_cost Neokowloon (talk) 04:50, 28 April 2021 (UTC)

And somehow there is lua error at Barrage#Gem_level_progression due to new life_cost parameter. Neokowloon (talk) 04:56, 28 April 2021 (UTC)

Decoration

The Template:Base item displayed "Requires %s" for all hideout decoration. Neokowloon (talk) 19:44, 11 July 2021 (UTC)