Talk: Query base items

Should extra_conditions be able to ignore other conditions?

Currently, it's possible to make the extra_conditions to ignore all the other conditions the template defines and I think that's outside the scope of these templates (There's {{SMW item table}} for those tables). {{Query unique items|extra_conditions=[[Has name::Blightwell]] OR [[Has name::Eyes of the Greatwolf]]}} displays

Eyes of the GreatwolfTalisman Tier: 4Requires Level 52

<Two random talisman implicit modifiers>
Projectiles Pierce 2 additional Targets +1 to maximum number of Raised Zombies (6-10)% increased Attack and Cast Speed (20-30)% increased Attack Damage (4-6)% chance to Freeze, Shock and Ignite 50% of Cold Damage from Hits taken as Fire Damage 50% of Cold Damage from Hits taken as Lightning Damage Gain (6-12)% of Physical Damage as Extra Damage of a random Element 10% chance to gain an Endurance Charge on Kill 50% of Fire Damage from Hits taken as Cold Damage 50% of Fire Damage from Hits taken as Lightning Damage 10% chance to gain a Frenzy Charge on Kill (15-25)% increased Global Defences (12-16)% increased Attributes (5-8)% increased Area of Effect (19-31)% increased Chaos Damage (20-30)% increased Cold Damage (40-50)% increased Global Critical Strike Chance +(24-36)% to Global Critical Strike Multiplier (25-35)% increased Damage (20-30)% increased Fire Damage (6-10)% increased Quantity of Items found (8-12)% increased maximum Life (20-30)% increased Lightning Damage (20-30)% increased maximum Mana (20-30)% increased Global Physical Damage 50% of Lightning Damage from Hits taken as Cold Damage 50% of Lightning Damage from Hits taken as Fire Damage Regenerate 2% of Life per second 10% chance to gain a Power Charge on Kill (4-6)% additional Physical Damage Reduction (20-30)% increased Spell Damage

Implicit Modifier magnitudes are doubled
CorruptedI am but a vessel for a greater force.
It acts through me. Speaks through me.
Decides what lives and dies through me.
And will change the world through me.

even though the template doesn't allow drop disabled items to show. This can be fixed with <q>{{{extra_conditions|}}}</q> if it's not intentional. --Illviljan (talk) 01:03, 23 November 2016 (UTC)

I agree. The template should be made more restrictive. Not sure how to go about that though. Maybe instead of leaving extra_conditions completely open ended, we can determine some useful customizations that are within the scope of what this template is supposed to do and create parameters for those. —Vini (t|c) 01:09, 23 November 2016 (UTC)

Yes, extra_conditions shouldn't have an ability to override the template conditions. I think it's safe to make the change. — TheFrz — 07:04, 23 November 2016 (UTC)

Done. This may affect tables that intentionally showed talismans and other drop disabled items. --Illviljan (talk) 12:23, 23 November 2016 (UTC)

This appears to have completely fubared the displaying of the tables on any of the pages. I'm going to revert for the time being. Durango (talk) 13:00, 23 November 2016 (UTC)

Reverted both of the template changes and the pages now display the tables properly. Durango (talk) 13:04, 23 November 2016 (UTC)

Which pages broke? It seems to work as intended on here: User:Illviljan/test4 --Illviljan (talk) 13:25, 23 November 2016 (UTC)

All the normal and unique item pages on Chrome, Firefox, and IE. As an example, this page: http://pathofexile.gamepedia.com/Axe had completely broken tables with nothing there. Your test page works, but none of the main item list pages were working. IIRC, it was giving a bad query error. Durango (talk) 14:36, 23 November 2016 (UTC)

Yeah, the query didn't like <q>{{{extra_conditions}}}</q> if extra_conditions is empty. Like it is in Axe. It should hopefully work now. --Illviljan (talk) 15:26, 23 November 2016 (UTC)